Skip to content

PHPLIB-430: Add test environment with multiple mongos nodes #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 5, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Aug 1, 2019

https://jira.mongodb.org/browse/PHPLIB-430

This PR changes the mongo-orchestration configs for sharded cluster to include a second mongos node for each. To ensure that we're not running into errors due to running subsequent commands on separate mongos instances, the tests modify the connection URI to only use a single mongos node, unless explicitly requested to use multiple nodes. This is currently only the case in select tests for the retryable-writes and transaction specs.

Note that some tests had to be disabled:

alcaeus added 5 commits August 1, 2019 13:39
For most tests, we only want to expose a single mongos node to avoid issues with fail points. This change parses and reassembles the connection URI to only return a single mongos node in the URI.
@alcaeus alcaeus requested a review from kvwalker August 1, 2019 12:57
@alcaeus alcaeus self-assigned this Aug 1, 2019
Copy link
Contributor

@kvwalker kvwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

alcaeus added a commit to alcaeus/mongo-php-library that referenced this pull request Aug 5, 2019
@alcaeus alcaeus merged commit f9452d8 into mongodb:master Aug 5, 2019
@alcaeus alcaeus deleted the phplib-430 branch August 5, 2019 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants