Skip to content

Remove unused imports #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove unused imports #672

wants to merge 1 commit into from

Conversation

piotr-cz
Copy link

Removed unused imports from code base.
Detected with Intelephense for VSCode.

@alcaeus
Copy link
Member

alcaeus commented Aug 26, 2019

Thank you for your contribution! These imports are all taken care of in #668, where we add comprehensive coding standards checks via phpcs. I'll look through your changes again once I've merged the pull request, but I suspect that all optimisations you've done here are taken care of by that PR already.

@piotr-cz
Copy link
Author

True, I've missed that #688.
Probably unused imports will be taken care of there. Once that PR is merged to master, I'll check again.

@alcaeus
Copy link
Member

alcaeus commented Aug 26, 2019

#668 has been merged, so go ahead if you want to check if there's anything else. I'd be surprised if phpcs missed anything 👍

@piotr-cz
Copy link
Author

Good job, there is nothing to complain now 👍

@piotr-cz piotr-cz closed this Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants