PHPLIB-330: Add property type hints #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Aug 27, 2019
alcaeus
force-pushed
the
phplib-330-property-types
branch
from
8b90915 to
2e88365
Compare
alcaeus
force-pushed
the
phplib-330-property-types
branch
from
2e88365 to
4a764fe
Compare
alcaeus
added a commit
that referenced
this pull request
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #668 that I extracted to keep the diff small. This PR adds
@varannotations to all properties in classes and partially enables theTypeHintSniff, requiring such property types to be declared. Declaring these types throughout the code helps with code completion, which currently doesn't always work because of missing type information.