PHPLIB-456: Always invalidate ChangeStream position if iteration fails #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Aug 28, 2019
| @@ -1125,34 +1125,21 @@ public function testResumeTokenNotFoundDoesNotAdvanceKey() | |||
| $changeStream->next(); | |||
| $this->fail('Exception for missing resume token was not thrown'); | |||
| } catch (ResumeTokenException $e) { | |||
There was a problem hiding this comment.
I would suggest leaving a comment in the body of each catch block or a combined comment above try that reminds us that the library will throw a client-side error for server < 4.1.8 and we can rely on a server-side error for >= 4.1.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-456
Contrary to the suggestion in the ticket, the implementation could not happen in
MongoDB\ChangeStream. Doing so would've required catching theResumeTokenExceptionthrown inMongoDB\Model\ChangeStreamIteratorand rethrowing it after updating itsvalidflag. To avoid this, I added the logic to the iterator itself, which now requires the cursor to be valid and also have a valid resume token to be considered valid.