Skip to content

PHPLIB-457: Add missing change stream prose test 14 #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2019
Merged

PHPLIB-457: Add missing change stream prose test 14 #675

merged 1 commit into from
Sep 4, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Sep 2, 2019

The logic of this is the same as in the test for the C driver (see link), which also uses startAtOperationTime to ensure a non-empty batch is returned when running without either startAfter and resumeAfter option.

@alcaeus alcaeus requested a review from jmikola September 2, 2019 12:39
@alcaeus alcaeus self-assigned this Sep 2, 2019
jmikola
jmikola approved these changes Sep 4, 2019 •
edited
Loading
View reviewed changes
jmikola
jmikola reviewed Sep 4, 2019
View reviewed changes
tests/Operation/WatchFunctionalTest.php

$this->insertDocument(['x' => 1]);

$changeStream->next();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should use advanceCursorUntilValid() from #659, since this test will also run on sharded clusters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to merge this before #659 since I'm still working on figuring out the cause for the double free. I'd like to go ahead with the merge then change this while rebasing #659.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

@jmikola jmikola self-requested a review September 4, 2019 01:11
jmikola
jmikola requested changes Sep 4, 2019
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change, which will require merging #659 first.

alcaeus added a commit that referenced this pull request Sep 4, 2019
@alcaeus
Merge pull request #675
7f24127
@alcaeus alcaeus merged commit 126e748 into mongodb:master Sep 4, 2019
@alcaeus alcaeus deleted the phplib-457 branch September 4, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola requested changes

Assignees

@alcaeus alcaeus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcaeus @jmikola