Skip to content

Assert initial resume token in resumeAfter test #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Sep 2, 2019

ChangeStream::getResumeToken() did not exist at the time this test was written; however, we do this assertion in testStartAfterOption().

This was originally suggested in #659, but fell out as a related change to testStartAfterOption() was no longer needed.

ChangeStream::getResumeToken() did not exist at the time this test was written; however, we do this assertion in testStartAfterOption().
@jmikola jmikola requested a review from alcaeus September 2, 2019 14:32
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

alcaeus added a commit that referenced this pull request Sep 2, 2019
@alcaeus alcaeus merged commit 6bf0671 into master Sep 2, 2019
@jmikola jmikola deleted the jmikola-patch-1 branch September 2, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants