Skip to content

PHPLIB-480: Deprecate MapReduce options #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

PHPLIB-480: Deprecate MapReduce options #695

merged 1 commit into from
Nov 13, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Nov 11, 2019

https://jira.mongodb.org/browse/PHPLIB-480

I've skipped the mapparams deprecation, as it's not possible to pass that option into the command through the helper.

@alcaeus alcaeus requested a review from jmikola November 11, 2019 11:32
@alcaeus alcaeus self-assigned this Nov 11, 2019
jmikola
jmikola approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't recall if you added tests for the CodeWScope deprecations, but if not I'm fine with skipping tests for these as well.

alcaeus added a commit that referenced this pull request Nov 13, 2019
@alcaeus
Merge pull request #695
384649d
@alcaeus alcaeus merged commit d23413a into mongodb:master Nov 13, 2019
@alcaeus alcaeus deleted the phplib-480 branch November 13, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

Assignees

@alcaeus alcaeus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alcaeus @jmikola