PHPLIB-502: Assert against transaction state #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Jan 24, 2020
| @@ -568,8 +568,7 @@ private function executeForTestRunner(FunctionalTestCase $test, Context $context | |||
| * instead exposes a bool to let us know whether a transaction | |||
| * is currently in progress. This code may fail down the line | |||
| * and should be adjusted once PHPC-1438 is implemented. */ | |||
| $expected = in_array($this->arguments['state'], ['in_progress', 'starting']); | |||
| $test->assertSame($expected, $args['session']->isInTransaction()); | |||
| $test->assertSame($this->arguments['state'], $args['session']->getTransactionState()); | |||
There was a problem hiding this comment.
I just realized this isn't documented. Added a label on PHPC-1438.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-502
This makes use of the new
getTransactionStateaccessor introduced in mongodb/mongo-php-driver#1061 to assert against the transaction state in spec tests.