PHPLIB-497: Allow passing hint to findAndModify update and replace operations #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
force-pushed
the
poc-spec-1398
branch
3 times, most recently
from
adbb3dc to
82e1a0e
Compare
jmikola
force-pushed
the
poc-spec-1398
branch
from
82e1a0e to
93d95ed
Compare
jmikola
changed the title
alcaeus
approved these changes
Jan 27, 2020
jmikola
changed the title
jmikola
force-pushed
the
poc-spec-1398
branch
from
80cf912 to
b6ed827
Compare
|
FYI, this originally failed with the intermittent double-free error on shutdown in the sharded replica set cluster (PHPC-1541). Re-kicking the build passed on the second attempt. |
jmikola
force-pushed
the
poc-spec-1398
branch
from
b6ed827 to
d437d45
Compare
|
Documentation has been added. |
jmikola
added a commit
that referenced
this pull request
Feb 14, 2020
jmikola
force-pushed
the
poc-spec-1398
branch
from
d437d45 to
01df441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-497
Created this to POC mongodb/specifications#650, but now that https://jira.mongodb.org/browse/SPEC-1398 is merged we can repurpose this for the implementation. I'll leave this in a waiting state since we don't want to merge until the 4.4-compat release.