PHPLIB-499: Handle absence of 'ns' field in index specifications returned from listIndexes #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
changed the title
jmikola
reviewed
Feb 12, 2020
jmikola
approved these changes
Feb 13, 2020
alcaeus
added a commit
that referenced
this pull request
Feb 14, 2020
|
Merged manually in 23e32dd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves as POC for the change. When creating an
IndexInfoIterator, we provide it with an optional namespace, which will be used for thensfield in the index information if it wasn't provided by the server (which will be the case for 4.4).This PR also deprecates the
getNamespacemethod for consistency with the server. We may want to keep the method, but considering that the namespace is no longer part of the index information returned by the server, we may opt to drop the method as well.