RetryableWriteError label spec tests #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Mar 10, 2020
| @@ -126,7 +126,7 @@ public static function fromRetryableReads(stdClass $operation, $defaultAssertion | |||
|
|
|||
| public static function fromRetryableWrites(stdClass $outcome, $defaultAssertionType) | |||
| { | |||
| if (property_exists($outcome, 'result')) { | |||
| if (property_exists($outcome, 'result') && ! self::isErrorResult($outcome->result)) { | |||
There was a problem hiding this comment.
Was this necessary because the retryable writes tests synced in this PR were the first to include error fields under an outcome.result object? For example:
"error": true,
"result": {
"errorLabelsContain": [
"RetryableWriteError"
]
},
There was a problem hiding this comment.
Yes, other tests didn’t include error results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PHPLIB-532 and PHPLIB-534. Verifies correct behaviour of error label changes to retryable writes.