Skip to content

DOCSP-10188: fix yaml file preventing docs build #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ccho-mongodb
Copy link

This yaml file entry needs to include the interface, operation, and optional keys for the documentation to build. Please review when you get the chance so that I can publish the docs, thanks!

@jmikola jmikola self-requested a review June 1, 2020 20:18
@jmikola jmikola changed the base branch from master to v1.7 June 1, 2020 20:19
@jmikola jmikola changed the base branch from v1.7 to master June 1, 2020 20:20
jmikola added a commit that referenced this pull request Jun 1, 2020
@jmikola
Copy link
Member

jmikola commented Jun 1, 2020

Manually merged to v1.7 in 8ff5758. Thanks!

@jmikola jmikola closed this Jun 1, 2020
@jmikola
Copy link
Member

jmikola commented Jun 1, 2020

@ccho-mongodb: The commit has also been merged up to master so it should fix the build for the "upcoming" branch in mongodb/docs-php-library@4daeded. Based on that, I assume nothing is building v1.7 directly, but perhaps it makes sense to briefly point "upcoming" to v1.7 and leave master dangling. I don't feel strongly either way, as v1.7 will become "current" in just a few weeks.

@ccho-mongodb
Copy link
Author

I see, could we also merge into master since I need to build the docs master branch (as well as every other version branch) in order to update the version selector?

@jmikola
Copy link
Member

jmikola commented Jun 1, 2020

This has already been merged to master in 81a57c0. That's what I meant by "has also been merged up to master" in my last comment :)

@ccho-mongodb
Copy link
Author

Ah sorry, missed that part. There's a strange bug in the version selector such that v1.7 is not redirecting to the appropriate content which I am currently chasing with the Docs Platform team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants