PHPLIB-569: Atlas Data Lake spec tests #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
changed the title
jmikola
changed the title
|
@jmikola I know you can't review your own PR, but if you could give the evergreen changes a quick look I'd appreciate it. Evergreen patch: https://spruce.mongodb.com/version/5f55e63a57e85a7177ac7fd7/tasks |
jmikola
commented
Sep 8, 2020
|
LGTM |
alcaeus
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-569
Tests synced with mongodb/specifications@bdc283c
This is waiting on Evergreen migration (PHPLIB-469). In the meantime, I've been testing locally with the following
phpunit.xmlmodification: