-
Notifications
You must be signed in to change notification settings - Fork 266
PHPLIB-562: Add basic matrix to test PHPLIB on evergreen #778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7df3b0f
to
3560e0f
Compare
- func: "bootstrap mongo-orchestration" | ||
vars: | ||
VERSION: "2.4" | ||
TOPOLOGY: "sharded_cluster" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at sharded_clusters/basic.json
and other MO configs in this PR, none appear to use replica sets. This means that PHPLIB won't actually be able to test change streams and transactions on sharded clusters.
Is there a separate PHPLIB ticket to add configs like we have in PHPC's scripts/presets/travis/sharded_clusters directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a dedicated tracking ticket for topologies, but I'll include them in PHPLIB-565 when expanding the version axis. I'll see if we need to add separate configs (similar to PHPC) and whether these configs should be contributed upstream to ensure all drivers can test sharded clusters backed by replica sets.
|
||
linux-rhel*) | ||
echo "Install RHEL dependencies" | ||
;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only empty because you're ignoring RHEL in the test matrix, or are no additional dependencies needed? I assume this might have been copied from PHPC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default file as copied over from the tools repository. We can remove this if we don't want dead code from the basic file here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in one of the commits ("unneded version string"), but not a problem if you intend on squashing.
|
||
linux-rhel*) | ||
echo "Install RHEL dependencies" | ||
;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections.
For the sake of completeness, one more patch build: https://spruce.mongodb.com/version/5f4de9b52fbabe0c4a292eb6/tasks |
PHPLIB-562
This adds a baseline of builds to evergreen. Note that PHP 7.0 is not available on all environments (which may be due to us using e.g. "rhel71-power8" over "rhel71-ppc", but I'll investigate as part of subsequent tickets.
@jmikola while reviewing, keep in mind that most of the new files in .evergreen are from the drivers tools repository. You'll want to focus on config.yml and install-dependencies.sh.