PHPLIB-563: Finalise PHP runtime axis #788
Conversation
| - { "os-php7": "rhel71-power8", "php-versions": "*", edge-versions: "*", "driver-versions": "*" } | ||
| # rhel74-zseries doesn't start in a timely fashion - most likely missing executors | ||
| - { "os-php7": "rhel74-zseries", "php-versions": "*", edge-versions: "*", "driver-versions": "*" } | ||
| display_name: "* ${os-php7}, PHP ${php-versions}, MongoDB ${edge-versions}, ext-mongodb ${driver-versions}" |
There was a problem hiding this comment.
Why does the display name start with an asterisk?
Should we use a consistent order with other display names? I noticed the "test-dependencies" matrix below has some of the components here in a different order.
There was a problem hiding this comment.
The asterisk is there to make sure these variants are sorted to the top of the list, as they are the ones we require for a PR to pass.
As for ordering in display names, I moved the main variant (e.g. PHP version in this case, MongoDB server version in other cases) to the front of the list. I have no objections against changing this if you prefer to have them alphabetically sorted in general.
There was a problem hiding this comment.
Oh, I see now that you're prioritizing the variable axes over the fixed ones, and in the "test-dependencies" matrix only the MongoDB version varies. That all makes sense to leave as-is.
| @@ -4,6 +4,10 @@ set -o errexit # Exit the script with error if any of the commands fail | |||
|
|
|||
| install_extension () | |||
| { | |||
| # Workaround to get PECL running on PHP 7.0 | |||
There was a problem hiding this comment.
Would it make sense to guard this in a conditional for PHP_VERSION starting with "7.0."?
https://stackoverflow.com/a/2172367/162228 suggests you could use if [[ $PHP_VERSION == 7.0.* ]]
There was a problem hiding this comment.
Despite me trying to use bash as a shell, I couldn't get evergreen to play nice:
[2020/09/22 08:21:34.150] + [[ 7.0.32 == 7.0.* ]]
[2020/09/22 08:21:34.150] [...]/.evergreen/install-dependencies.sh: 8: [...]/.evergreen/install-dependencies.sh: [[: not found
Since this has no negative impact on other PHP versions, I'd use this unconditionally, especially since 7.0 is the next PHP version we'll drop support for (although no timeline for this exists).
PHPLIB-563
This PR makes a few last changes to the pipeline:
Pull requests currently test the "test-php-versions" pipeline, which tests the driver on all PHP versions and several operating systems against the latest server. I'm open to adding additional variants/tasks to the mix, but thought that those were a good starting point.