PHPLIB-597: Replace direct PHPUnit dependency with symfony/phpunit-bridge #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Oct 22, 2020
jmikola
approved these changes
Oct 22, 2020
alcaeus
force-pushed
the
phpunit-bridge
branch
from
7e8ac39 to
3829b5d
Compare
alcaeus
force-pushed
the
phpunit-bridge
branch
from
3829b5d to
20236e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-597
This is a prerequisite to get tests going on PHP 8. PHPUnit makes it impossible to run tests on PHP 7 - PHP 8, and the PHPUnit bridge fixes that problem for us.
This PR introduces a new trait for the constraint polyfill, as PHPUnit 9 changes the method signature for
Constraint::evaluatewhich we override. These changes will be contributed back to Symfony (hopefully for inclusion in 5.2).