PHPLIB-598: Clean up cursor usages to account for iterator changes #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Jan 15, 2021
|
@jmikola I made the changes you suggested to the docs. Note that the three failing builds are due to a recent change to the Symfony PHPUnit Bridge which prevents it from working on PHP 7.0. I'll take care of this in a separate PR. |
jmikola
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-598
@jmikola I decided to clean up the tailable cursor docs as well and add a note about needing to wrap cursors in an
IteratorIteratorbefore manually iterating. Let me know if you'd rather keep the original documentation intact and add a note that wrapping is no longer necessary with 1.9.0+.