PHPLIB-608 Fix wrong validity check in CachingIterator #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
Suggested refactoring but LGTM.
Side note: reviewing this made me realize that CachingIterator would break if the wrapped Traversable had non-unique keys. I opened PHPLIB-609 to track that.
| */ | ||
| public function testWithWrongIterator() | ||
| { | ||
| $nestedIterator = new class implements Iterator { |
There was a problem hiding this comment.
What a lovely use of anonymous classes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-608
Note that this does not affect 1.8, as
CachingIteratoralways wraps the given traversable in anIteratorIterator, which corrects this wrong behaviour in underlying iterators. In the upcoming 1.9 release, this is no longer the case for any traversable that implements theIteratorinterface, so this wrong behaviour can lead to extra elements given (hence the test failures).