PHPLIB-607 Support Azure and GCP keystores in FLE #809
Conversation
alcaeus
force-pushed
the
phplib-607
branch
4 times, most recently
from
fe90095 to
6136514
Compare
|
Note: evergreen build failures are due to RHEL 7.0 failing OCSP verification for the Azure certificate. This also appears in the C driver builds, so I want to take a look and try to remedy this. |
alcaeus
force-pushed
the
phplib-607
branch
2 times, most recently
from
f61fcc8 to
525a5e3
Compare
.evergreen/config.yml
Outdated
| display_name: "1.9.0" | ||
| variables: | ||
| DRIVER_VERSION: "1.9.0" | ||
| # TODO: Update matrix once v1.10 has been branched |
There was a problem hiding this comment.
Is this just limiting driver versions to provide quicker feedback on CI builds? Is this something to change before or after merging this PR?
Separate from this comment, I'm not sure why "latest-stable" is left in place instead of commenting everything and leaving only "latest-dev".
There was a problem hiding this comment.
Disabling latest-stable would've required me changing a number of matrix entries below, which I wanted to avoid. I'll revisit and see how I can make this a little more resilient regarding such changes, since this typically happens during every version cycle.
There was a problem hiding this comment.
The only thing I came up with was renaming latest-stable to latest to account for it potentially being a dev version. I've held off on making the change but want to revisit this separately.
There was a problem hiding this comment.
I think the TODO comment can be revised. Before we branch v1.10 (usually happens when we start the first work on v1.11), we can revert this to "stable" as soon as the 1.10 release ships.
There was a problem hiding this comment.
I've updated this. From the commit:
- Add more detailed comment about re-enabling driver versions
- Rename latest-stable to latest to account for varying stability
- Prepare correct versions for 1.10-dev and 1.11-dev
alcaeus
force-pushed
the
phplib-607
branch
2 times, most recently
from
b6c4601 to
789f811
Compare
|
@jmikola @kevinAlbs I've skipped the azureKMS spec tests until the certificate issue on RHEL has been fixed. I've created PHPLIB-619 to track this (which again depends on the upstream CDRIVER issue). |
.evergreen/config.yml
Outdated
| display_name: "1.9.0" | ||
| variables: | ||
| DRIVER_VERSION: "1.9.0" | ||
| # TODO: Update matrix once v1.10 has been branched |
There was a problem hiding this comment.
I think the TODO comment can be revised. Before we branch v1.10 (usually happens when we start the first work on v1.11), we can revert this to "stable" as soon as the 1.10 release ships.
* Add more detailed comment about re-enabling driver versions * Rename latest-stable to latest to account for varying stability * Prepare correct versions for 1.10-dev and 1.11-dev
PHPLIB-607
Counterpart to mongodb/mongo-php-driver#1196.
Note that the changes in the GitHub Actions workflow is to support providing secrets for workflows as well. At the moment, this is not used.
I also discovered that we weren't running any FLE tests on Evergreen due to missing credentials. This PR rectifies this.