PHPLIB-617 Continuous Matrix Testing for 4.0 era drivers #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Feb 11, 2021
alcaeus
force-pushed
the
v1.4-matrix-testing
branch
5 times, most recently
from
155c65c to
14ea7e9
Compare
alcaeus
force-pushed
the
v1.4-matrix-testing
branch
2 times, most recently
from
017215c to
0518305
Compare
alcaeus
force-pushed
the
v1.4-matrix-testing
branch
from
0518305 to
49650ea
Compare
alcaeus
commented
Feb 15, 2021
jmikola
reviewed
Feb 17, 2021
alcaeus
force-pushed
the
v1.4-matrix-testing
branch
7 times, most recently
from
b7436ce to
df68b88
Compare
alcaeus
force-pushed
the
v1.4-matrix-testing
branch
from
df68b88 to
cbe4898
Compare
alcaeus
force-pushed
the
v1.4-matrix-testing
branch
from
cbe4898 to
2129841
Compare
|
New patch build: https://spruce.mongodb.com/version/602e562f5623434b3f2cc74c/tasks Testing against 4.2 and 4.4 passes thanks to some well-placed skips, but I have to investigate the failures on latest as they occur in spec tests. I'd call this done for the time being and revisit the failures once I can see how the 4.2 and 4.4 drivers fare. |
alcaeus
force-pushed
the
v1.4-matrix-testing
branch
11 times, most recently
from
2617c72 to
b8fe579
Compare
alcaeus
force-pushed
the
v1.4-matrix-testing
branch
from
b8fe579 to
ba0c0f8
Compare
|
@jmikola Tests now all pass, except for the occasional failure on replica sets due to a double free (our old friend has returned): https://spruce.mongodb.com/version/602f72fc9ccd4e172a60e6e8/tasks |
jmikola
approved these changes
Feb 19, 2021
| if ($this->isShardedCluster()) { | ||
| return $this->getServerVersion($readPreference); | ||
| } | ||
|
|
There was a problem hiding this comment.
Yes. Fixed a number of tests 😉
| ;; | ||
| esac | ||
|
|
||
| PHPUNIT_OPTS="--dont-report-useless-tests --exclude-group matrix-testing-server-${MONGODB_VERSION_NUMBER}-driver-${DRIVER_MONGODB_VERSION},matrix-testing-server-${MONGODB_VERSION_NUMBER}-driver-${DRIVER_MONGODB_VERSION}-topology-${TOPOLOGY}" |
There was a problem hiding this comment.
Yeah, not happy about the formatting, but your suggestion to use groups to skip tests was great.
alcaeus
added a commit
to alcaeus/mongo-php-library
that referenced
this pull request
Feb 19, 2021
* v1.4: PHPLIB-617 Continuous Matrix Testing for 4.0 era drivers (mongodb#810)
alcaeus
added a commit
that referenced
this pull request
Feb 19, 2021
* v1.4: PHPLIB-617 Continuous Matrix Testing for 4.0 era drivers (#810)
alcaeus
added a commit
that referenced
this pull request
Mar 4, 2021
* v1.5: Rename matrix testing exclusion groups PHPLIB-616 Continuous Matrix Testing for 4.2 era drivers (#812) PHPLIB-617 Continuous Matrix Testing for 4.0 era drivers (#810)
alcaeus
added a commit
that referenced
this pull request
Mar 4, 2021
* v1.6: Rename matrix testing exclusion groups PHPLIB-616 Continuous Matrix Testing for 4.2 era drivers (#812) PHPLIB-617 Continuous Matrix Testing for 4.0 era drivers (#810)
alcaeus
added a commit
that referenced
this pull request
Mar 5, 2021
* v1.7: PHPLIB-615 Matrix testing for 4.4 era drivers (#813) Rename matrix testing exclusion groups PHPLIB-616 Continuous Matrix Testing for 4.2 era drivers (#812) PHPLIB-617 Continuous Matrix Testing for 4.0 era drivers (#810)
alcaeus
added a commit
that referenced
this pull request
Mar 9, 2021
* v1.8: Fix test failures due to wrong merge PHPLIB-615 Matrix testing for 4.4 era drivers (#813) Rename matrix testing exclusion groups PHPLIB-616 Continuous Matrix Testing for 4.2 era drivers (#812) PHPLIB-617 Continuous Matrix Testing for 4.0 era drivers (#810)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-617
Since this version is not tested on evergreen yet, this includes the minimal scripts required to test on evergreen without adding an evergreen configuration.