PHPLIB-622 Versioned MongoDB API for Drivers #816
Conversation
alcaeus
force-pushed
the
phplib-622
branch
2 times, most recently
from
bbc13f2 to
d6d9c63
Compare
alcaeus
force-pushed
the
phplib-622
branch
2 times, most recently
from
7532582 to
3d3233d
Compare
.evergreen/run-tests.sh
Outdated
| @@ -12,6 +12,7 @@ AUTH=${AUTH:-noauth} | |||
| SSL=${SSL:-nossl} | |||
| MONGODB_URI=${MONGODB_URI:-} | |||
| TESTS=${TESTS:-} | |||
| export API_VERSION=${API_VERSION:-} | |||
There was a problem hiding this comment.
Should the list in "Supported/used environment variables" above be updated? It looks like it's out of sync with what's happening here.
Also, is there a reason we use export here but not in other lines? I do see it's used for EXTENSION_VERSION below, but nothing else.
There was a problem hiding this comment.
API_VERSION is used in the tests, while the others are used in this script, hence the export to avoid having to modify the call to phpunit below.
There was a problem hiding this comment.
MONGODB_URI is also used by PHPUnit and it doesn't have an export line.
There was a problem hiding this comment.
Hm, no idea why I added it since it also works without.
.evergreen/run-tests.sh
Outdated
| @@ -12,6 +12,7 @@ AUTH=${AUTH:-noauth} | |||
| SSL=${SSL:-nossl} | |||
| MONGODB_URI=${MONGODB_URI:-} | |||
| TESTS=${TESTS:-} | |||
| export API_VERSION=${API_VERSION:-} | |||
There was a problem hiding this comment.
MONGODB_URI is also used by PHPUnit and it doesn't have an export line.
|
One outstanding question about |
This syncs the versioned API spec tests to commit a49cbdf605176a7035c0343779170ce412cc3f0e
PHPLIB-622
Docs are part of #815. Currently tests against a WIP version of ext-mongodb, which I'll remove once mongodb/mongo-php-driver#1204 is merged.