PHPLIB-657: Skip incompatible unified tests and resync CRUD #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
May 18, 2021
This restores several missing tests and skips incompatible tests for unacknowledged writes using hint. The db-aggregate tests will also be skipped until schemaVersion 1.4 is implemented (serverless testing). Synced with mongodb/specifications@c06e4c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-657
https://jira.mongodb.org/browse/PHPLIB-645
The skipping of tests within
db-aggregate.jsonis unfortunate, but it should be temporary until schemaVersion 1.4 is implemented. See DRIVERS-1130 for more details. On the bright side, we do get a newaggregate.jsontest.Incompatible tests for unacknowledged writes using hints are explicitly skipped (see: DRIVERS-991 and DRIVERS-1340 for context).