PHPLIB-654 Remove deprecated terminology #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
May 24, 2021
jmikola
approved these changes
May 24, 2021
|
Updated to reflect review feedback. Waiting for mongodb/mongo-php-driver#1221 to be merged before merging. |
alcaeus
changed the title
alcaeus
changed the title
jmikola
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
LGTM with commit message revision.
The commit for syncing spec tests refers to alcaeus@6d7fd37, which still seems incorrect. Please update to mongodb/specifications@... if you have the corresponding specs commit hash handy.
Updates spec tests to commit mongodb/specifications#6d7fd374ca14a80edabeefdd27cdd6187c43a0eb
|
Build failures are addressed in #835, merging despite failing CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-654
Tests against my test version, which I'll remove before merging.