PHPLIB-664, PHPLIB-676, and PHPLIB-703: APM redaction and observeSensitiveCommands #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Jul 27, 2021
tanlisu
reviewed
Jul 28, 2021
jmikola
force-pushed
the
phplib-664-and-676
branch
from
b8f42cc to
735b38e
Compare
jmikola
changed the title
Implements observeSensitiveCommands, which was introduced in unified test format schema version 1.5. Synced with mongodb/specifications@289f405
Co-authored-by: Andreas Braun <[email protected]>
Co-authored-by: Tanli Su <[email protected]>
jmikola
force-pushed
the
phplib-664-and-676
branch
from
735b38e to
332fa64
Compare
alcaeus
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-664
https://jira.mongodb.org/browse/PHPLIB-676
https://jira.mongodb.org/browse/PHPLIB-703
Note: this also depended on fixing a missing
use functionstatement in 105e728 (also fixed in v1.9 branch).