PHPLIB-694: Spec tests for snapshot sessions #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
force-pushed
the
phplib-694
branch
2 times, most recently
from
1de8c49 to
2c7aaf8
Compare
alcaeus
approved these changes
Aug 6, 2021
|
What is a prose test as opposed to a spec test (referred to in the JIRA ticket)? |
Spec tests are written in YML/JSON and executed using a test runner. Prose tests are expressed in written text and implemented manually. The corresponding prose test for this work was defined in https://github.com/mongodb/specifications/blob/master/source/sessions/tests/README.rst#prose-tests and implemented in mongodb/mongo-php-driver@ac49353#diff-f526132129853b0d00c150317c2cb972ac2d17d32e05fed83a6313d91fadcecf |
jmikola
commented
Aug 9, 2021
tanlisu
approved these changes
Aug 9, 2021
|
LGTMs noted. Will leave this open until mongodb/specifications#1046 is merged and I can update the commit reference. |
This is necessary to pull in changes from PHPC-1761 for testing snapshot sessions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-694
Syncs tests with mongodb/specifications/pull/1046 (will be updated once merged).
Temporarily reduces the
driver-versionsaxis in the Evergreen matrix tolatest-devto pull in changes from PHPC-1761.