Avoid some deprecations with PHP 8.1 #865
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those arguments are always passed by the data providers.
franmomu
force-pushed
the
fix_deprecations
branch
from
e958b0d to
4b19f66
Compare
|
There is another deprecation passing an object to the not sure what to do there, maybe just type cast to |
|
@franmomu: I created PHPLIB-766 to track this and am looking into it now. Thanks! |
|
I've incorporated the commits in this PR into #874. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They appear on the CI: https://github.com/mongodb/mongo-php-library/runs/3530599314#step:10:6237 and also when adding support to
doctrine/mongodb-odm: https://github.com/doctrine/mongodb-odm/pull/2378/checks?check_run_id=3903213010#step:11:13