PHPLIB-662: Unified test runner should error for unexpected operation arguments #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
changed the title
jmikola
reviewed
Mar 11, 2022
All requested changes are implemented.
jmikola
requested changes
Mar 20, 2022
|
@aleksandr-rudo: I noticed in #896 that you manually applied the same suggestions I left. In case you're not familiar with the feature, take a look at applying suggested changes (that may save time for this PR). You can batch them up so that they apply in a single commit, which will then be immediately tested by CI. If you need to continue development on the branch locally, you'll want to pull down changes from your remote fork first, though. And at merge time, we can always squash the commits and ignore the "Suggestions from code review" commit(s). |
Implementing all suggested changes, i.e. reorganizing "runCommand" items, reorganizing "createIndex" items, updating "startTransaction" items, updating "withTransaction" items and updating "assertArgumentsBySchema" function content. Co-authored-by: Jeremy Mikola <[email protected]>
jmikola
reviewed
Mar 23, 2022
There was a problem hiding this comment.
@aleksandr-rudo: It looks like there are two more coding standard issues to fix. vendor/bin/phpcbf should be able to take care of those for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-662