Skip to content

PHPLIB-748: Support 'let' option for multiple CRUD commands #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 18, 2022

Conversation

aleksandr-rudo
Copy link
Contributor

@aleksandr-rudo aleksandr-rudo requested a review from jmikola April 7, 2022 21:25
@jmikola
Copy link
Member

jmikola commented Apr 8, 2022

@aleksandr-rudo: Feel free to sync the CRUD spec tests with mongodb/specifications#1174. You can temporarily write Synced with mongodb/specifications#1174 in the commit message for now and we can update that to the final commit once that works is merged.

I don't think there will be any spec test changes, so the only further work for you should be amending the commit message. In the meantime, pulling in the new JSON files should allow us to pass CI here, and let this PR server as a proof of concept (POC).

@jmikola
Copy link
Member

jmikola commented Apr 11, 2022

@aleksandr-rudo: I forgot to mention this earlier but we'll also need to document the new option.

You can review commits for /docs for examples of how this was done for previous PRs. The most relevant, recent commit may be when let was added for aggregate() in a4b172c.

The docs are built with separate tooling, which is briefly discussed in CONTRIBUTING.md. You can try to get that running locally, but if you run into trouble I'm happy to just test the changes you make and fix any mistakes in the interest of time. The docs themselves are RST files with separate includes for method parameters and options, and the method-specific include files can inherit common includes (viewing previous commits where options were documented should help explain how everything is organized).

@jmikola
Copy link
Member

jmikola commented Apr 11, 2022

mongodb/specifications#1174 is merged so feel free to update the sync commit to point to mongodb/specifications@51ca03b

@jmikola
Copy link
Member

jmikola commented Apr 14, 2022

#913 was just merged and pulls in the same tests, since the sync commit was more recent. You can either rebase this branch on master or merge master into your branch (in which case the merge commit produced will disappear when we finally merge this PR).

I also added skips for existing spec tests in that PR, so I expect you will just need to remove the skips I added for the let tests.

@jmikola
Copy link
Member

jmikola commented Apr 15, 2022

@aleksandr-rudo: I just took a look through each file again. Let me know when this is ready for a final review by flipping it from draft status and I'll check it out locally and build the docs to confirm all is well there.

@aleksandr-rudo aleksandr-rudo marked this pull request as ready for review April 15, 2022 11:26
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs build locally. LGTM.

I opened PHPLIB-842 to track the intermittent change stream spec tests failures.

@aleksandr-rudo aleksandr-rudo merged commit bf85cb9 into mongodb:master Apr 18, 2022
@aleksandr-rudo aleksandr-rudo deleted the phplib-748 branch April 18, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants