Skip to content

PHPLIB-879: Convert command monitoring tests to unified format #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented May 23, 2022

https://jira.mongodb.org/browse/PHPLIB-879

POC for mongodb/specifications#1221. Commit message will be updated after that PR is merged.

@jmikola jmikola requested a review from aleksandr-rudo May 23, 2022 18:09
@jmikola
Copy link
Member Author

jmikola commented May 23, 2022

Two test failures are related to this discussion I opened on the specs PR:

1) MongoDB\Tests\UnifiedSpecTests\UnifiedSpecTest::testCommandMonitoring with data set "command-monitoring/commands: A successful command with a non-primary read preference" (MongoDB\Tests\UnifiedSpecTests\UnifiedTestCase Object (...))
Unsupported keys: readPreference
Failed asserting that an array is empty.

2) MongoDB\Tests\UnifiedSpecTests\UnifiedSpecTest::testCommandMonitoring with data set "command-monitoring/find: A successful find with options" (MongoDB\Tests\UnifiedSpecTests\UnifiedTestCase Object (...))
Unsupported keys: readPreference
Failed asserting that an array is empty.

@jmikola jmikola merged commit f2cfb9f into mongodb:master May 31, 2022
@jmikola jmikola deleted the phplib-879 branch June 7, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants