-
Notifications
You must be signed in to change notification settings - Fork 266
PHPLIB-820: Key Management API spec tests #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
928c83f
Unified CSFLE spec tests for key management API
jmikola 98d318a
Support runOnRequirement.csfle
jmikola f866a64
Support clientEncryption entity and $$placeholder syntax
jmikola 2871e7e
ClientEncryption operations
jmikola cf04535
Note ClientEncryption's parent client to ensure events are observed
jmikola b19deae
Set ClientEncryption tlsOptions when KMIP endpoint is used
jmikola 9ce148c
Prepare RewrapManyDataKeyResult for expectResult assertion
jmikola 022c294
Update Evergreen config to test against PHPC master branch
jmikola e51710f
Prose test for unique index on keyAltNames
jmikola 866b325
PHPLIB-929: Prose test for rewrapManyDataKey
jmikola 72af6d9
Do not consider SkippedTest exceptions as errors for valid-fail tests
jmikola e8e2405
Remove trailing comma in argument list
jmikola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting for the benefit of @levon80999 and others that may want to run these tests: I suggest defining these secrets in a
phpunit.xml
file based onphpunit.xml.dist
. This file takes precedence over the dist file and is in gitignore, allowing your own configuration to be added.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was actually helpful for me as well. I was previously using a shell script to export the environment variables before calling
vendor/bin/simple-phpunit
, butphpunit.xml
is much nicer.