PHPLIB-945: Update ChangeStreamEvent type definition to include clusterTime #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add the sync commit (mongodb/specifications@d9a0e7b) to your commit message. |
|
Note: recent discussion in DRIVERS-2025 indicates that there will be a follow-up ticket to update this spec test. I suggest holding off on merging so that we can re-use PHPLIB-945 and this PR for the second ticket that will soon be created. |
levon80999
force-pushed
the
PHPLIB-945
branch
from
72f84d2 to
538d4af
Compare
|
Per my comment in PHPLIB-945, please sync with mongodb/specifications@1a3b359. |
|
@levon80999: Note that my earlier feedback from #971 (comment) has not been addressed. |
|
@jmikola sorry for late answer, I saw your comment but too busy to fix one CI fail on my other PR, I will end it today and immediately switch to this task |
levon80999
force-pushed
the
PHPLIB-945
branch
3 times, most recently
from
0f93033 to
44f7095
Compare
alcaeus
approved these changes
Sep 27, 2022
levon80999
added a commit
to levon80999/mongo-php-library
that referenced
this pull request
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-945
Sync with mongodb/specifications@1a3b359