PHPLIB-638: Ensure writeConcernError is reported for findAndModify #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levon80999
force-pushed
the
PHPLIB-638
branch
2 times, most recently
from
d11c0a6 to
996522c
Compare
alcaeus
requested changes
Sep 30, 2022
alcaeus
reviewed
Sep 30, 2022
levon80999
force-pushed
the
PHPLIB-638
branch
from
9831441 to
1b71ed6
Compare
levon80999
force-pushed
the
PHPLIB-638
branch
from
1b71ed6 to
90611f3
Compare
alcaeus
approved these changes
Sep 30, 2022
jmikola
reviewed
Sep 30, 2022
| } | ||
|
|
||
| $this->expectException(CommandException::class); | ||
| $this->expectExceptionCode(100); |
There was a problem hiding this comment.
Note: this is "UnsatisfiableWriteConcern" per https://github.com/mongodb/mongo/blob/master/src/mongo/base/error_codes.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-638