PYTHON-2057 Make 'name' a required argument for DriverInfo class (#718)

Author: juliusgeo

doc/changelog.rst

@@ -100,6 +100,7 @@ Breaking Changes in 4.0
 - Removed :class:`bson.binary.UUIDLegacy`.
 - The "tls" install extra is no longer necessary or supported and will be
   ignored by pip.
+- ``name`` is now a required argument for the :class:`pymongo.driver_info.DriverInfo` class.
 
 Notable improvements
 ....................

doc/migrate-to-pymongo4.rst

@@ -725,3 +725,10 @@ pymongo.message helpers are removed
 Removed :meth:`pymongo.message.delete`, :meth:`pymongo.message.get_more`,
 :meth:`pymongo.message.insert`, :meth:`pymongo.message.kill_cursors`,
 :meth:`pymongo.message.query`, and :meth:`pymongo.message.update`.
+
+
+Name is a required argument for pymongo.driver_info.DriverInfo
+..............................................................
+
+``name`` is now a required argument for the :class:`pymongo.driver_info.DriverInfo` class.
+

pymongo/driver_info.py

@@ -26,7 +26,7 @@ class DriverInfo(namedtuple('DriverInfo', ['name', 'version', 'platform'])):
     like 'MyDriver', '1.2.3', 'some platform info'. Any of these strings may be
     None to accept PyMongo's default.
     """
-    def __new__(cls, name=None, version=None, platform=None):
+    def __new__(cls, name, version=None, platform=None):
         self = super(DriverInfo, cls).__new__(cls, name, version, platform)
         for key, value in self._asdict().items():
             if value is not None and not isinstance(value, str):

test/test_client.py

@@ -305,6 +305,8 @@ def test_metadata(self):
         self.assertRaises(ValueError, MongoClient, appname='x' * 129)
         # Bad "driver" options.
         self.assertRaises(TypeError, DriverInfo, 'Foo', 1, 'a')
+        self.assertRaises(TypeError, DriverInfo, version="1", platform='a')
+        self.assertRaises(TypeError, DriverInfo)
         self.assertRaises(TypeError, MongoClient, driver=1)
         self.assertRaises(TypeError, MongoClient, driver='abc')
         self.assertRaises(TypeError, MongoClient, driver=('Foo', '1', 'a'))