Skip to content

fix wrong urllib parse function being used to percent encode usernames and passwords, where before spaces would be incorrectly encoded to '+' instead of '%20' which is behaviour for a different usecase #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix wrong urllib parse function being used to percent encode usernames and passwords, where before spaces would be incorrectly encoded to '+' instead of '%20' which is behaviour for a different usecase #1186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/examples/authentication.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ Username and password must be percent-escaped with

>>> from pymongo import MongoClient
>>> import urllib.parse
>>> username = urllib.parse.quote_plus('user')
>>> username = urllib.parse.quote('user')
>>> username
'user'
>>> password = urllib.parse.quote_plus('pass/word')
>>> password = urllib.parse.quote('pass/word')
>>> password
'pass%2Fword'
>>> MongoClient('mongodb://%s:%[email protected]' % (username, password))
Expand Down