Skip to content

PYTHON-4672 Clarify Reauthentication and Speculative Authentication combination behavior #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 23, 2024

Conversation

blink1073
Copy link
Member

No description provided.

Comment on lines 1058 to 1060
for event in listener.started_events:
if event.command_name.lower() != "saslstart":
found = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be event.command_name.lower() == "saslstart"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks!

@blink1073 blink1073 requested a review from Jibola August 22, 2024 02:27
Copy link
Contributor

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blink1073 blink1073 merged commit 7ee08dd into mongodb:master Aug 23, 2024
35 checks passed
@blink1073 blink1073 deleted the PYTHON-4672 branch August 23, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants