-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-4667 Handle $clusterTime from error responses in client Bulk Write #1822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5010f8b
PYTHON-4667 Handle from error responses in client Bulk Write
blink1073 000fdcb
address review
blink1073 00fda16
fix typing
blink1073 879f8d0
fix var handling
blink1073 b57b32b
address review
blink1073 48b059f
address review
blink1073 e8bbb16
simplify
blink1073 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -281,6 +281,7 @@ async def write_command( | |
) | ||
if bwc.publish: | ||
bwc._succeed(request_id, reply, duration) # type: ignore[arg-type] | ||
await client._process_response(reply, bwc.session) # type: ignore[arg-type] | ||
except Exception as exc: | ||
duration = datetime.datetime.now() - bwc.start_time | ||
if isinstance(exc, (NotPrimaryError, OperationFailure)): | ||
|
@@ -308,6 +309,11 @@ async def write_command( | |
|
||
if bwc.publish: | ||
bwc._fail(request_id, failure, duration) | ||
# Process the response from the server. | ||
if isinstance(exc, OperationFailure): | ||
await client._process_response(exc.details, bwc.session) # type: ignore[arg-type] | ||
else: | ||
await client._process_response({}, bwc.session) # type: ignore[arg-type] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't need an There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed |
||
raise | ||
finally: | ||
bwc.start_time = datetime.datetime.now() | ||
|
@@ -449,7 +455,6 @@ async def _execute_batch( | |
else: | ||
request_id, msg, to_send = bwc.batch_command(cmd, ops) | ||
result = await self.write_command(bwc, cmd, request_id, msg, to_send, client) # type: ignore[arg-type] | ||
await client._process_response(result, bwc.session) # type: ignore[arg-type] | ||
|
||
return result, to_send # type: ignore[return-value] | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isinstance(exc, (NotPrimaryError, OperationFailure))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done