PYTHON-4703 MongoClient should default to connect=False on FaaS environments #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Sep 6, 2024
doc/changelog.rst
Outdated
| @@ -42,13 +42,19 @@ PyMongo 4.9 brings a number of improvements including: | |||
| - Fixed a bug where PyMongo would raise ``InvalidBSON: date value out of range`` | |||
| when using :attr:`~bson.codec_options.DatetimeConversion.DATETIME_CLAMP` or | |||
| :attr:`~bson.codec_options.DatetimeConversion.DATETIME_AUTO` with a non-UTC timezone. | |||
| - The default value for ``connect`` in ``MongoClient`` is changed to ``False`` when running on | |||
| Function-as-a-service (FaaS). On some FaaS systems, there is a ``fork()`` operation at function | |||
There was a problem hiding this comment.
Suggest adding Function-as-a-service (FaaS) like AWS Lambda, Google Cloud Functions, and Microsoft Azure Functions.
| @@ -18,6 +19,9 @@ | |||
| ServerHeartbeatListener, | |||
| ) | |||
|
|
|||
| # Ensure there are no warnings raised in normal operation. | |||
| warnings.simplefilter("error") | |||
ShaneHarvey
reviewed
Sep 6, 2024
| @@ -803,7 +803,10 @@ def __init__( | |||
| if tz_aware is None: | |||
| tz_aware = opts.get("tz_aware", False) | |||
| if connect is None: | |||
| connect = opts.get("connect", True) | |||
| # Default to connect=True unless on a FaaS system, which might use fork. | |||
There was a problem hiding this comment.
Suggest adding a versionchanged and updating the docstring for connect.
ShaneHarvey
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.