Skip to content

PYTHON-2357 Specify error label in retryable writes test #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2020
Merged

PYTHON-2357 Specify error label in retryable writes test #494

merged 3 commits into from
Oct 2, 2020

Conversation

ShaneHarvey
Copy link
Member

@ShaneHarvey ShaneHarvey commented Oct 1, 2020 •
edited
Loading

Two changes:

  • PYTHON-2357 Specify error label in retryable writes test (simply resyncs the tests).
  • PYTHON-2356 Add errorLabelsContain/errorLabelsOmit support to retryable writes tests (implemented by transforming the retryable write test into the transaction test format).

prashantmital
prashantmital approved these changes Oct 2, 2020
View reviewed changes
test/test_retryable_writes.py
self.assertIsNotNone(error, 'should have raised an error')
else:
self.assertIsNone(error)
crud_v1_check_result(self, outcome['result'], result)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import on L41 seems unused after this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@ShaneHarvey ShaneHarvey merged commit 1c2651b into mongodb:master Oct 2, 2020
@ShaneHarvey ShaneHarvey deleted the PYTHON-2357 branch October 2, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantmital prashantmital prashantmital approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaneHarvey @prashantmital