PYTHON-2344 Update TLS examples to use unified TLS URI options #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
commented
Oct 16, 2020
|
|
||
| If the private key for the client certificate is stored in a separate file use | ||
| the `ssl_keyfile` option:: |
There was a problem hiding this comment.
I've kept in ssl_keyfile because we currently still support it. https://jira.mongodb.org/browse/PYTHON-2396 will figure out if we want to remove it in PyMongo 4.0.
prashantmital
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
This LGTM but I couldn't find a ticket where we would rename the internal names for these options to the TLS*-equivalents. Currently, the ssl* names are used everywhere internally in the PyMongo codebase. Do you think we should have a ticket for changing that slated for PyMongo 4.0?
Sure. We could even do it sooner since it's all internal only names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.