PYTHON-2457 Test that clients wait 500ms between failed heartbeat checks #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review although I still need to create a PYTHON ticket to track the work. |
patrickfreed
approved these changes
Dec 1, 2020
ShaneHarvey
force-pushed
the
SPEC-1764-poc
branch
from
4bc4b24 to
bf6356d
Compare
ShaneHarvey
changed the title
prashantmital
suggested changes
Dec 7, 2020
| # Force a connection. | ||
| client.admin.command('ping') | ||
| duration = time.time() - start | ||
| self.assertGreaterEqual(duration, 2) |
There was a problem hiding this comment.
Can you add comments here that explain the math? E.g.
# isMaster attempted 5 times with 500 ms between checks => duration > 4 * 500ms
self.assertGreaterEqual(duration, 2)
There was a problem hiding this comment.
Added a link to the spec and an explanation like the previous version of the test.
| client.admin.command('ping') | ||
| duration = time.time() - start | ||
| self.assertGreaterEqual(duration, 2) | ||
| self.assertLessEqual(duration, 3.5) |
There was a problem hiding this comment.
How do you arrive at 3.5s?
There was a problem hiding this comment.
There was a problem hiding this comment.
I added it as a generous upper bound to account for any timing differences in the various test runner implementatinos. Drivers should really take between 2 and 2.5 seconds (depending on when the timer was started and how fast the monitors start up).
prashantmital
approved these changes
Dec 8, 2020
ShaneHarvey
added a commit
to ShaneHarvey/mongo-python-driver
that referenced
this pull request
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: mongodb/specifications#879