PYTHON-2482 Test Versioned API with a server started with acceptAPIVersion2 #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
commented
Jan 13, 2021
| @@ -6,7 +6,8 @@ | |||
| "minServerVersion": "4.7", | |||
| "serverParameters": { | |||
| "enableTestCommands": true, | |||
| "acceptAPIVersion2": true | |||
| "acceptAPIVersion2": true, | |||
| "requireApiVersion": false | |||
There was a problem hiding this comment.
This was added in mongodb/specifications#893
| display_name: "acceptAPIVersion2" | ||
| tags: [ "versionedApi_tag" ] | ||
| variables: | ||
| ORCHESTRATION_FILE: "versioned-api-testing.json" |
There was a problem hiding this comment.
I reworked this section slightly because in one case we want to test two different cases:
- against a cluster with requireApiVersion=1 and with
MONGODB_API_VERSION - against a cluster without requireApiVersion without
MONGODB_API_VERSIONbut with acceptAPIVersion2.
ShaneHarvey
force-pushed
the
PYTHON-2482
branch
from
67567e9 to
f5cb670
Compare
.evergreen/config.yml
Outdated
| variables: | ||
| # REQUIRE_API_VERSION is set to make drivers-evergreen-tools | ||
| # start a cluster with the requireApiVersion parameter. | ||
| REQUIRE_API_VERSION: "1" | ||
| # MONGODB_API_VERSION is the apiVersion to use in the test suite. | ||
| MONGODB_API_VERSION: "1" | ||
| # Test against a cluster acceptAPIVersion2 but without requireApiVersion=0. |
There was a problem hiding this comment.
without requireApiVersion=0 or without requireApiVersion=1? What does version 0 mean?
There was a problem hiding this comment.
Updated the comment to actually make sense.
prashantmital
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change: