PYTHON-1321 Remove MongoReplicaSetClient #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behackett
requested changes
Jan 16, 2021
doc/migrate-to-pymongo4.rst
Outdated
| --------------------- | ||
|
|
||
| Removed :class:`~pymongo.mongo_replica_set_client.MongoReplicaSetClient`. | ||
| Use :class:`pymongo.mongo_client.MongoClient` instead. |
There was a problem hiding this comment.
I'd suggest mentioning that since PyMongo 3.0 MongoReplicaSetClient has been a trivial wrapper for MongoClient that only overrode repr, to make it clear that the migration literally only requires a change of class name.
There was a problem hiding this comment.
Done. I didn't mention the repr though.
behackett
approved these changes
Jan 16, 2021
ShaneHarvey
force-pushed
the
PYTHON-1321
branch
from
077463c to
d05b9d7
Compare
|
Rebased to fix a merge conflict in the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.