PYTHON-1320 Remove legacy CRUD methods #556
Conversation
Remove save, insert, update, remove, and find_and_modify.
| @@ -24,7 +24,7 @@ warning: | |||
|
|
|||
| .. code-block:: python | |||
|
|
|||
| # "insert.py" | |||
| # "insert.py" (with PyMongo 3.X) | |||
There was a problem hiding this comment.
This section provides example output for deprecation warnings which only work on PyMongo 3.X (because PyMongo 4.0 removes all the deprecated APIs).
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2009-2015 MongoDB, Inc. | |||
There was a problem hiding this comment.
This benchmark actually works now.
There was a problem hiding this comment.
This benchmark isn't great and never really has been. Let's just get rid of it.
| # Can't use fsync and j options together | ||
| self.assertRaises(ConfigurationError, WriteConcern, j=True, fsync=True) | ||
| # Can't use w=0 and j options together | ||
| self.assertRaises(ConfigurationError, WriteConcern, w=0, j=True) |
There was a problem hiding this comment.
Added this test to avoid loosing test coverage when deleting test_legacy_api.
| wait_until(lambda: 2 == db.collection_4.count_documents({}), | ||
| 'insert 2 documents', timeout=60) | ||
|
|
||
| db.collection_4.drop() |
There was a problem hiding this comment.
Added these tests to avoid loosing test coverage when deleting test_legacy_api.
| @@ -220,9 +223,9 @@ is displayed: | |||
| .. code-block:: javascript | |||
|
|
|||
| > // mongo shell. | |||
| > db.collection.insert( { "_id" : 1, "subdocument" : { "b" : 1, "a" : 1 } } ) | |||
| > db.collection.insertOne( { "_id" : 1, "subdocument" : { "b" : 1, "a" : 1 } } ) | |||
There was a problem hiding this comment.
The shell has implemented the CRUD spec for a while now.
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2009-2015 MongoDB, Inc. | |||
There was a problem hiding this comment.
This benchmark isn't great and never really has been. Let's just get rid of it.
Remove save, insert, update, remove, and find_and_modify.