-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-2162 Remove support for ssl* URI options #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
prashantmital
merged 26 commits into
mongodb:master
from
prashantmital:PYTHON-2702/removed-deprecated-URI-options
Aug 19, 2021
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
fd50ca1
PYTHON-2702 Removed deprecated names for renamed URI options
prashantmital ae1358a
Remove ssl_ca_certs
prashantmital d285d3d
Remove ssl_crlfile
prashantmital 6f24cdb
Remove ssl_match_hostname
prashantmital ebd1d4d
Remove ssl_cert_reqs
prashantmital 93cbf38
Remove ssl_certfile and ssl_keyfile
prashantmital e236f8b
remove unused ssl option cruft
prashantmital deca485
Rename OCSP option to tls*
prashantmital 1c4303b
Remove cruft
prashantmital b0f197b
Update migration guide
prashantmital f5fdc9a
Fix failing tests
prashantmital 8449cc6
ensure semantics for security options dont change
prashantmital 5847213
normalize before validation
prashantmital 4f2f350
fix tls option handling
prashantmital 566f027
fix handling tlsallowinvalidcertificates
prashantmital 045dd73
Merge branch 'master' into PYTHON-2702/removed-deprecated-URI-options
prashantmital ec12ee6
fix typo
prashantmital 7aec629
review changes
prashantmital ef822ce
review changes
prashantmital 5eeffb1
fix test_normalize_options test
prashantmital 8ed1aef
fix ssl tests
prashantmital b5924c4
get DNS test passing
prashantmital e8db6f0
review changes
prashantmital c393433
debug failures - 1
prashantmital 1f2f6ba
debug failures - 2
prashantmital 48daa20
debug failures - 3
prashantmital File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove ssl here (and INTERNAL_URI_OPTION_NAME_MAP) as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the decision was made to keep
ssl
indefinitely since we never deprecated it? Do you think we should deprecate it in the next 3.x release and remove?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note also that the follow up PR to this will be a better place remove this kind of bookkeeping code as that PR will get rid of all remaining options that have been deprecated in 3.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right that we should keep it. The URI-options spec still has
ssl
and doesn't say to remove it. It might be helpful to ask other drivers what their plan is.