PYTHON-2680 Breaking changes to DBRef BSON+JSON decoding #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng JSON Skip UUID hyphens test.
…g TODO: C extensions PYTHON-2841 resync bson corpus tests
ShaneHarvey
force-pushed
the
PYTHON-2680
branch
from
a094215 to
ec2ab33
Compare
ShaneHarvey
commented
Sep 9, 2021
| @@ -202,7 +202,10 @@ def _get_object(data, view, position, obj_end, opts, dummy): | |||
| obj = _elements_to_dict(data, view, position + 4, end, opts) | |||
|
|
|||
| position += obj_size | |||
| if "$ref" in obj: | |||
| # If DBRef validation fails, return a normal doc. | |||
There was a problem hiding this comment.
This is the breaking DBRef BSON decoding change.
| if "$ref" in dct: | ||
| if (isinstance(dct.get('$ref'), str) and | ||
| "$id" in dct and | ||
| isinstance(dct.get('$db'), (str, type(None)))): |
There was a problem hiding this comment.
This is the breaking DBRef JSON decoding change.
behackett
approved these changes
Sep 10, 2021
ShaneHarvey
changed the title
|
@juliusgeo I've merged this without waiting for your review but please take a look through this change anyway. Feel free to ask any questions you might have. |
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Oct 1, 2021
Implement DBRef spec version 1.0 tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still TODO: