Skip to content

RUBY-2841 Ignore read pref if any pre-5.0 #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2021
Merged

RUBY-2841 Ignore read pref if any pre-5.0 #2370

merged 1 commit into from
Nov 17, 2021

Conversation

comandeo
Copy link

Ignore read preference for $out/$merge on secondaries if any servers are pre-5.0.

behackett
behackett approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@behackett behackett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hopeless at Ruby, but the logic looks right to me.

@comandeo comandeo merged commit 6f3717b into mongodb:master Nov 17, 2021
@comandeo comandeo deleted the 2841-ignore-rp-for-pre-5.0 branch November 17, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behackett behackett behackett approved these changes

@alexbevi alexbevi Awaiting requested review from alexbevi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@comandeo @behackett @comandeo-mongo