RUBY-2525 Expose the Reason an Operation Fails Document Validation #2379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilshweky
commented
Dec 7, 2021
p-mongo
reviewed
Dec 13, 2021
lib/mongo/error/operation_failure.rb
Outdated
| # For WriteErrors this is `document['writeErrors'][0]['errInfo']`. | ||
| # For all other errors this is nil. | ||
| # | ||
| # @since 2.11.0 |
There was a problem hiding this comment.
We no longer use @since tags and this one isn't accurate, since the functionality will be added in 2.18. You can remove this @since tag and, if others are in your way going forward, feel free to get rid of them also.
p-mongo
reviewed
Dec 13, 2021
| it 'succeeds and prints the error' do | ||
| begin | ||
| collection.insert_one({x: 1}) | ||
| rescue Mongo::Error => e |
There was a problem hiding this comment.
This should be Mongo::Error::OperationFailure, given the else branch below.
p-mongo
approved these changes
Dec 14, 2021
comandeo
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to add a details property to the
OperationFailureclass to better conform with the crud spec.This attribute is defined as follows:
document['writeConcernError']['errInfo'].document['writeErrors'][0]['errInfo'].nil.Now, this makes a lot of sense for the OperationFailure class, but for BulkWriteError it doesn't quite make sense. The problem is that BulkWriteError can have multiple writeErrors inside it. This is troublesome because I'm not sure what to do with the
detailsnow. Should it be a list of theerrInfos of eachwriteError? This didn't seem to make sense, so I just left the details off theBulkWriteErrorclass. If the user wants to find that information, they can get there from theresultsattr_reader.Evergreen Patch