RUBY-2833 Add KMIP Support #2383
Conversation
comandeo
force-pushed
the
2833-add-kmip-support
branch
from
9d120d7 to
705341d
Compare
comandeo
force-pushed
the
2833-add-kmip-support
branch
from
705341d to
6754792
Compare
| wait_for_kms_server() { | ||
| for i in $(seq 60); do | ||
| # Exit code 7: "Failed to connect to host". | ||
| if curl -s "localhost:$1"; test $? -ne 7; then |
There was a problem hiding this comment.
Wouldn't it better to require status 0 than anything other than 7?
There was a problem hiding this comment.
Some of mock servers we start have bad configurations - wrong certificates, etc. So, curl won't be able to connect to them "good enough" to return 0. Hence check for "anything but Failed to connect".
There was a problem hiding this comment.
How about adding the -k option in this case?
There was a problem hiding this comment.
Just adding -k didnt't work. I end up with this - curl -d '' -X POST -k https://localhost:8002/, which works (== returns 0) for almost all mock servers. Unfortunately, an attempt to connect to mock server with --require_client_cert option will give us error code 56.
There was a problem hiding this comment.
OK, whatever you think is best is good with me.
comandeo
force-pushed
the
2833-add-kmip-support
branch
from
53b2d73 to
73c3e64
Compare
comandeo
force-pushed
the
2833-add-kmip-support
branch
from
73c3e64 to
6f6f116
Compare
This reverts commit 633ab2e.
No description provided.