Skip to content

RUBY-2090 RUBY-2638 Move driver DBRef class to bson-ruby #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 28, 2021
Merged

RUBY-2090 RUBY-2638 Move driver DBRef class to bson-ruby #2391

merged 6 commits into from
Dec 28, 2021

Conversation

neilshweky
Copy link
Contributor

@neilshweky neilshweky commented Dec 20, 2021 •
edited
Loading

The tests are currently failing in this PR because it's not pointing to the correct version of bson-ruby. This PR needs to be merged before it can work: mongodb/bson-ruby#257

Things left to do for this PR:

  1. up the required bson-ruby
  2. add release notes that we moved DBRef to bson-ruby
  3. Document the fact that if you pass an invalid DBRef to the DBRef constructor, you will get an error, but if you pass it to the extjson parser, you will get a hash... bson-ruby/docs/tutorials/bson-v4.txt

@neilshweky neilshweky requested a review from p-mongo December 23, 2021 21:20
@p-mongo p-mongo requested a review from comandeo December 28, 2021 05:09
@neilshweky neilshweky merged commit 9b83f62 into mongodb:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comandeo comandeo comandeo approved these changes

@p-mongo p-mongo p-mongo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neilshweky @comandeo @p-mongo @p