RUBY-2869 Do not use mutexes in finalizers #2417
Conversation
| kill_spec.db_name, | ||
| kill_spec.service_id | ||
| ].join(MSG_SEPARATOR) | ||
| @pipe_write.puts(msg) |
There was a problem hiding this comment.
This call can block if the pipe is full. My understanding is there needs to be a thread that is constantly reading the pipe to ensure the writing side doesn't block indefinitely.
There was a problem hiding this comment.
Have you considered https://ruby-doc.org/core-2.5.0/Queue.html ?
There was a problem hiding this comment.
I have, but Queue is thread safe, and according to its docs "The Queue class implements all the required locking semantics." So, we may encounter the same problem with queue. I'll do some testing, though. If it works, I would prefer queue over pipe here.
There was a problem hiding this comment.
Changed to queue, seems to be safe.
comandeo
force-pushed
the
2869-fix-mutexes-in-finalizers
branch
from
d267a53 to
a1fb68e
Compare
|
I think it is more correct to use server addresses ( |
Good point, changed accordingly. |
Finalizers are called from signal trap, so mutexes do not work there (see https://github.com/ruby/ruby/blob/master/thread_sync.c#L288).